Add support for PIM Group management #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better matches the underlying resource and means we don't need to negate the bool
Preparation for doing Directory and DirectoryRole resources
Rename some fields to make more sense
kenchan0130
reviewed
Apr 5, 2024
docs/resources/privileged_access_group_assignment_schedule_request.md
Outdated
Show resolved
Hide resolved
kenchan0130
reviewed
Apr 5, 2024
docs/resources/privileged_access_group_eligibility_schedule_request.md
Outdated
Show resolved
Hide resolved
|
@manicminer Could we trouble you to review? A bunch of folks in #68 are eagerly awaiting the changes in this PR. |
…id (#1) Add role management policy data source
manicminer
approved these changes
May 8, 2024
There was a problem hiding this comment.
Thank you @oWretch for this PR and @iwarapter for collaborating!
Apologies for the delay in reviewing. This looks fantastic and I have no changes to request - the only substantive change I've made was to fix up the azuread_group_role_management_policy data source test.
Tests are passing and this LGTM! 🚀 🚀 🚀 🌕
This was referenced May 8, 2024
Closed
dduportal
pushed a commit
to jenkins-infra/azure
that referenced
this pull request
May 10, 2024
<Actions>
<action
id="6d17e7acdb2f3311576150379e22805f2f9b4aa72ff00ec136aceee45cae4b98">
<h3>Bump Terraform `azuread` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
<summary>Update Terraform lock file</summary>
<p>changes detected:
	"hashicorp/azuread" updated from
"2.48.0" to "2.49.0" in file
".terraform.lock.hcl"</p>
<details>
<summary>2.49.0</summary>
<pre>Changelog retrieved
from:
	https://github.com/hashicorp/terraform-provider-azuread/releases/tag/v2.49.0
FEATURES:

*
**New Data Source:** `azuread_group_role_management_policy`
([#1327](hashicorp/terraform-provider-azuread#1327
**New Resource:** `azuread_group_role_management_policy`
([#1327](hashicorp/terraform-provider-azuread#1327
**New Resource:** `azuread_privileged_access_group_assignment_schedule`
([#1327](hashicorp/terraform-provider-azuread#1327
**New Resource:** `azuread_privileged_access_group_eligibility_schedule`
([#1327](hashicorp/terraform-provider-azuread#1327
**New Resource:** `azuread_synchronization_job_provision_on_demand`
([#1032](https://github.com/hashicorp/terraform-provider-azuread/issues/1032))

ENHANCEMENTS:

*
`data.azuread_group` - support for the `include_transitive_members`
property
([#1300](hashicorp/terraform-provider-azuread#1300
`azuread_application` - relax validation for the `identifier_uris`
property to allow more values
([#1351](hashicorp/terraform-provider-azuread#1351
`azuread_application_identifier_uri` - relax validation for the
`identifier_uri` property to allow more values
([#1351](hashicorp/terraform-provider-azuread#1351
`azuread_group` - support the `SkipExchangeInstantOn` value for the
`behaviors` property
([#1370](hashicorp/terraform-provider-azuread#1370
`azuread_user` - relax validation for the `employee_type` property to
allow more values
([#1328](https://github.com/hashicorp/terraform-provider-azuread/issues/1328))

BUG
FIXES:

* `azuread_application_pre_authorized` - fix a
destroy-time bug that could prevent deletion of the resource
([#1299](https://github.com/hashicorp/terraform-provider-azuread/issues/1299))


</pre>
</details>
</details>
<a
href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/158/">Jenkins
pipeline link</a>
</action>
</Actions>
---
<table>
<tr>
<td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
</td>
<td>
<p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
</p>
<details><summary>Options:</summary>
<br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
<ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
</ul>
<p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
</p>
</details>
</td>
</tr>
</table>
Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge of #1320, #1322, #1324.
Closes #68, #1164, #1186, #1257.
Depends on manicminer/hamilton#277.
Bumps
hamiltonto v0.67.0Provides three new resources:
azuread_group_role_management_policyazuread_privileged_access_group_assignment_scheduleazuread_privileged_access_group_eligibility_scheduleProvides one new data source
azuread_group_role_management_policythanks to @iwarapter